[sqllab] add autocomplete to AceEditor for table and column names#1475
Merged
mistercrunch merged 2 commits intoapache:masterfrom Oct 29, 2016
Merged
[sqllab] add autocomplete to AceEditor for table and column names#1475mistercrunch merged 2 commits intoapache:masterfrom
mistercrunch merged 2 commits intoapache:masterfrom
Conversation
ascott
reviewed
Oct 29, 2016
| setAutoCompleter() { | ||
| // Loading table and column names as auto-completable words | ||
| const completer = { | ||
| getCompletions: (aceEditor, session, pos, prefix, callback) => { |
There was a problem hiding this comment.
i would pull this out into it's own method on the component, otherwise LGTM
bkyryliuk
reviewed
Oct 29, 2016
| const columns = {}; | ||
| const tables = this.props.tables || []; | ||
| tables.forEach(t => { | ||
| words.push({ name: t.name, value: t.name, score: 55, meta: 'table' }); |
Member
There was a problem hiding this comment.
could be nice to differentiate tables or views, optional
Member
|
Looks good! |
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ascott @vera-liu @bkyryliuk
fixes #1428 , #1418